Move hash based actions to be event triggered #395
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done in preparation for #388. This PR moves toolbox's current hash processing to an event based system which allows us to easily hook in other things as well.
Initially I also wanted to implement things so that when a relative url is clicked to the settings that the state of the url is changed instead it reloading the page. However there is some fuckery going on with reddit urls making that a bit more difficult than I'd like. I briefly debated simply doing it for all
a
elements that open toolbox settings (and just ignoring whatever url they are pointing to) but I have no idea how people link to settings in regards to mod onboarding so I decided against that.I'll do #388 in a separate PR once this is merged.